Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (947cfdd) to head (81addf3).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #3611   +/-   ##
=======================================
  Coverage   86.86%   86.87%           
=======================================
  Files         127      127           
  Lines       15271    15287   +16     
  Branches       62       62           
=======================================
+ Hits        13265    13280   +15     
- Misses       1851     1852    +1     
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

we need to add validation check for the field workerConnection, just to ensure that any value other than the valid range is rejected by the spec

we need to add validation check for the field workerConnection, just to ensure that any value other than the valid range is rejected by the spec

@salonichf5 I would disagree. This validation that you linked is mainly to ensure secure string values in nginx config to avoid injection. In this case, we are using an integer, and nginx has no limitations on the value (that I'm aware of). So in that case, I think it's fine to let our CRD schema handle validation upfront.

we need to add validation check for the field workerConnection, just to ensure that any value other than the valid range is rejected by the spec

@salonichf5 I would disagree. This validation that you linked is mainly to ensure secure string values in nginx config to avoid injection. In this case, we are using an integer, and nginx has no limitations on the value (that I'm aware of). So in that case, I think it's fine to let our CRD schema handle validation upfront.

sounds good, my initial assumption was to do this for all fields. But the above makes sense.

@salonichf5 Totally fair. It's a conversation we've gone back and forth on in the past. I think we settled on doing the extra validation on fields that could represent security concerns, otherwise let the CRD schema handle it.